Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

feat: pass through middleware config, noDefaultRoute option (proposal) #454

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abetaev
Copy link

@abetaev abetaev commented Jul 2, 2022

this is the proposal

as a user of webrtc-star transport i want finer control over signalling server middleware to be able to:

  1. host web app which uses that signalling server
  2. provide CORS configuration for other web apps to make them able to communicate with this signalling server

i had to explicitly set test runtimes in aegir config in transport package because somehow it was trying to run tests within webworker runtime which does not (yet?) support WebRTC. i have no explanation for that. i use npm test command to run all tests

@abetaev abetaev force-pushed the feat/expose-middleware-config branch from e264346 to c0369b7 Compare September 16, 2022 23:30
@abetaev abetaev marked this pull request as ready for review September 16, 2022 23:41
@abetaev abetaev force-pushed the feat/expose-middleware-config branch from c0369b7 to 68d7345 Compare October 1, 2022 20:04
@abetaev abetaev force-pushed the feat/expose-middleware-config branch from 68d7345 to c7d444f Compare October 19, 2022 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant